Added factory interfaces, removed concrete type declaration, added ty… #5996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes to properties where missing.
…ke Interface replacement properly working.
bytes-commerce
commented
Oct 31, 2023
| { | ||
| private static array $doctrineTypeToFieldFqcn = [ | ||
| private array $doctrineTypeToFieldFqcn = [ |
There was a problem hiding this comment.
Actually, having this as private constant makes most sense; its not going to get modified anyway by the code and statics should be avoided.
There was a problem hiding this comment.
since it's used for guessing, I agree.
bytes-commerce
commented
Oct 31, 2023
| { | ||
| private AdminContextProvider $adminContextProvider; | ||
| private iterable $filterConfigurators; | ||
| private static array $doctrineTypeToFilterClass = [ | ||
| private array $doctrineTypeToFilterClass = [ |
There was a problem hiding this comment.
Same here, nothing writes to it, it should be a constant.
oleg-andreyev
approved these changes
Nov 6, 2023
| { | ||
| private static array $doctrineTypeToFieldFqcn = [ | ||
| private array $doctrineTypeToFieldFqcn = [ |
There was a problem hiding this comment.
since it's used for guessing, I agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pes to properties where missing.
This is the second PR to introduce more APIs to the repository for
finalclasses. This time, it will introduce specific interfaces for Factories.