Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small edits worth considering (first contribution in EMC community) #58

Merged
merged 17 commits into from
May 7, 2024

Conversation

dopecello
Copy link
Contributor

Hi everyone!

I am dopecello, I am currently aspiring to be a software developer professionally and am interested in contributing to EarthMC, a server that I love very much.

I made some commits to my forked repository that provide more information to users who decide to read the documentation. I also improved some of the navigability to some pages (for example, town.mdx was using a custom_edit_url instead of a slug for land claiming) and improved some consistency across pages.

Would be honored to contribute more and help make EarthMC an even better server than it already is!

src/docs/economy.mdx Outdated Show resolved Hide resolved
src/docs/economy.mdx Outdated Show resolved Hide resolved
src/docs/nation.mdx Outdated Show resolved Hide resolved
src/docs/nation.mdx Outdated Show resolved Hide resolved
src/docs/nation.mdx Outdated Show resolved Hide resolved
src/docs/town.mdx Outdated Show resolved Hide resolved
Copy link
Member

@jwkerr jwkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these things should be fixed

Copy link
Contributor Author

@dopecello dopecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the last sentence in economy.mdx would be great. I just ran it once through ChatGPT and I think it reads very well.

src/docs/economy.mdx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@dopecello dopecello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fruitloopins fixed spacing, let me know if this is the desired format

@DasCodes
Copy link
Collaborator

Hi @dopecello, thanks for the PR but your package-lock.json with get conflicted since Docusaurus has been upgraded to version 3. Could you get that fixed?

@dopecello
Copy link
Contributor Author

Ok, should be good to go!

@DasCodes DasCodes requested a review from jwkerr May 5, 2024 18:32
@jwkerr jwkerr merged commit 20466e2 into EarthMC:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants