Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3674 - Use dynamic libraries from boost in OSX #259

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

tcezard
Copy link
Member

@tcezard tcezard commented Sep 27, 2024

And reverted the integration of statically linked libraries

@tcezard tcezard changed the title Use dynamic libraries from boost EVA-3674 - Use dynamic libraries from boost in OSX Sep 30, 2024
Copy link
Collaborator

@vasudeva8 vasudeva8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

The 'export LIBRARY_PATH' for Mac in build.yml for GitHub action may not be relevant anymore and we may remove as well. There is no harm in retaining it either.

CMakeLists.txt Outdated
@@ -87,7 +87,7 @@ if (LINUX)
elseif (OSX)
# Mac build not fully static. include system libraries to be dynamic
set (CMAKE_EXE_LINKER_FLAGS)
set (Boost_USE_STATIC_LIBS ON) # only find static libs
set (Boost_USE_STATIC_LIBS OFF) # only find static libs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the comment be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tcezard tcezard merged commit 1edca3e into EBIvariation:master Oct 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants