Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS4 preferredRoots not working #598

Closed
grlloyd opened this issue Nov 28, 2023 · 3 comments
Closed

OLS4 preferredRoots not working #598

grlloyd opened this issue Nov 28, 2023 · 3 comments
Assignees
@haideriqbal
Labels
bug Medium priority Affects more than one ontology with mild reduction in usability

Comments

@grlloyd
Copy link

grlloyd commented Nov 28, 2023

Describe the bug
Using the preferredRoots endpoint returns Status 500: Internal Server Error

To Reproduce
Steps to reproduce the behavior:

  1. Run curl https://www.ebi.ac.uk/ols4/api/ontologies/GO/terms/preferredRoots
  2. See error

Expected behavior
The same as using the roots endpoint but filtered to only include terms where is_preferred_root=true

Additional context
preferredRoots is not documented for the previous OLS version; is it a new feature?
@grlloyd grlloyd added the bug label Nov 28, 2023
@haideriqbal haideriqbal added the Medium priority Affects more than one ontology with mild reduction in usability label Jun 12, 2024
@haideriqbal
Copy link
Collaborator

This is a bug in the code and needs to be fixed. Thanks for reporting @grlloyd

@haideriqbal haideriqbal self-assigned this Aug 6, 2024
@haideriqbal
Copy link
Collaborator

This PR #714 fixes it

@haideriqbal
Copy link
Collaborator

Its now live in production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haideriqbal haideriqbal

Labels
bug Medium priority Affects more than one ontology with mild reduction in usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grlloyd @haideriqbal