Fix parabolic bowl registry for MPAS-Ocean init mode #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbegeman
reviewed
Sep 18, 2023
components/mpas-ocean/src/mode_init/Registry_parabolic_bowl.xml
Outdated
Show resolved
Hide resolved
There were a few syntax issues with the MPAS-Ocean registry for the parabolic bowl test case that prevent it from being parsed correctly in Polaris. They are fixed here.
xylar
force-pushed
the
mpas-ocean/fix-parabolic-bowl-registry
branch
from
6594c25
to
f755e37
Compare
xylar
commented
Sep 18, 2023
xylar
added
the
MPAS-Ocean standalone
xylar
changed the title
|
@sbrus89, waiting for your review on this one, when you have time. |
sbrus89
reviewed
Sep 22, 2023
components/mpas-ocean/src/mode_init/Registry_parabolic_bowl.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Steven Brus <[email protected]>
jonbob
added a commit
that referenced
this pull request
Sep 26, 2023
… (PR #5930) Fix parabolic bowl registry for MPAS-Ocean init mode There were a few syntax issues with the MPAS-Ocean registry for the parabolic bowl test case that prevent it from being parsed correctly in Polaris. They are fixed here. Not used in E3SM. [BFB]
|
passes:
merged to next |
|
merged to master |
|
@jonbob, thank you very much! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few syntax issues with the MPAS-Ocean registry for the parabolic bowl test case that prevent it from being parsed correctly in Polaris. They are fixed here.