Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing and grouping writable #706

Open
xozy22 opened this issue Oct 8, 2024 · 10 comments
Open

Spacing and grouping writable #706

xozy22 opened this issue Oct 8, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@xozy22
Copy link

xozy22 commented Oct 8, 2024

Hey developers,
I saw in merge requests, that spacing is planned to be writable.
Do you also plan to make grouping accessible + writable?
When do you plan the next release?
Thanks in Advance!

@xozy22 xozy22 added the enhancement New feature or request label Oct 8, 2024
@DutchmanNL
Copy link
Contributor

Can you please clarify a little what you mean with grouping and if there is an APi endpoint available (otherwise I will have to research for it and not used ales quite some time but more than happy to extend the code)

@xozy22
Copy link
Author

xozy22 commented Oct 8, 2024

Hi @DutchmanNL,

"spc" and "grp" should be available also via API:
https://kno.wled.ge/interfaces/json-api/

That implementation would be quite useful to realize "spots" in the led-stripe.
As you can see in the following video:
https://youtu.be/M8xCgQUihd8?feature=shared

If you need any other information please ping me.
I try to help also with testing if necessary.
Thanks!

@DutchmanNL
Copy link
Contributor

@xozy22 thank you, if provided by API/websocket it should be straight forward to implement

I'm an business travel until end of next week :/

Please do me a favour, send me a reminder next weekend, just need to flash an esp here and evaluate the api

@HaggardFFM
Copy link
Contributor

HaggardFFM commented Oct 9, 2024

Hi @DutchmanNL ,
I checked this, and the datapoints are still in the stateAttr.js but not marked as writeable.
I can change this and post a pull request.

But have you the issue #698 in the scope.
There was an error with axios by the last beta build. Please correct this before you generate a next beta.

Greeting Haggard

@xozy22
Copy link
Author

xozy22 commented Oct 9, 2024

Hi @HaggardFFM,
yes, you are right for "spc" datapoint.
"grp" datapoint seems not integrated yet, correct?
https://github.com/DrozmotiX/ioBroker.wled/blob/f0f9de80ffca3caad83f1b3bcba7e9084168d165/lib/stateAttr.js#L223C1-L226C1

BR

@xozy22
Copy link
Author

xozy22 commented Oct 9, 2024

@HaggardFFM
Sorry, did not saw your commit #707
Thanks for your work so far!
Then @DutchmanNL, you should really only have #698 in mind.

BR

@HaggardFFM
Copy link
Contributor

Hi @xozy22,
these DATAPOINTS are integrated, so you see them in the Objecttree of WLED, but they was not writable.
So I changed this, and send a pull request for integrate it to the main repo.
After @DutchmanNL build a new Beta Version, you can install it in your IOBROKER and test it.
But there was another problem with the last beta, so @DutchmanNL has to check it first,
BR

@xozy22
Copy link
Author

xozy22 commented Oct 9, 2024

@HaggardFFM
Just testet your implementation, but I will roll back to stable until @DutchmanNL fixed the other issue.
image
image

Thank you all! Very appreciating!
BR

@DutchmanNL
Copy link
Contributor

Hi @xozy22,

these DATAPOINTS are integrated, so you see them in the Objecttree of WLED, but they was not writable.

So I changed this, and send a pull request for integrate it to the main repo.

After @DutchmanNL build a new Beta Version, you can install it in your IOBROKER and test it.

But there was another problem with the last beta, so @DutchmanNL has to check it first,

BR

Thank you clarifying that Safes me quite some time understanding those relationships!

Will look into the mentioned connection issue und merge the changes

DutchmanNL added a commit that referenced this issue Oct 11, 2024
Update stateAttr.js Solves  enhancement #706
@DutchmanNL
Copy link
Contributor

should be solved, please try latest version from git (0.7.3-beta.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants