-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Firefox and Cloud Sync (GitHub Gist) support #291
Comments
I was wondering whether it would be possible to synchronise tab groups using Firefox Sync, too. My idea was to sync them as bookmarks (loosing history, but that is OK for me), potentially storing the group names in tags (allows having the same tab belong to multiple groups) or using bookmark folders (allowing just one group per tab, if that is more desirable from a design / implementation perspective). |
+1 |
Hi all, I have been trying to implement this for a long time, but there is a restriction:
If you have a lot of tabs, the data size will be more than 100KB. And then the problem, the solution of which adds only more problems ... |
Is there any way to make us see the total of all tabs in Firefox sync? Because when I move tabs to groups, on my other device I only see tabs which are in the open group, tabs from other groups are not shown and hence inaccessible. As a use case, I use groups at work to group my work-related tabs into logical parts. When I get home and want to come back to some of my work tabs, I only see the active group tabs in my synced tabs, and other tabs are only accessible from my work device. |
I understand that synchronizing all tabs seems difficult, but it would be nice if at least we can synchronize groups and settings |
The solution is to allow backup of groups to bookmarks as in #328, that way you have 100KB data in firefox sync to store configuration. |
Hi all! I added option to export groups to bookmarks, you can sync groups/bookmarks this way |
Sorry, maybe I'm dumb, but I don't understand how I should use the new bookmark export to resolve syncing use cases. Can I set it up so that all my groups are periodically automatically bookmarked? Or can I only do it manually for each group? |
@hluposti you're quite right in that, this is not an automatic process.
Not currently, but maybe the author is working on some magic here :)
Currently this is the case. The current implementation in #328 is not fully automatic. It can backup automatically, but not restore automatically. So it's not really a sync though it can kind of be used that way in a manual process. To implement sync functionality using #328, the author would need to use the functionality implemented in #328 a little bit differently. One potential design approach would be to create a "SimpleTabGroupsSync" BookMark Folder, which STG would then automatically write all current STG Window groups. Second he would need to read this group if it exists on startup to make sure that the sync'ed bookmarks and the the current STG window groups match. To do this requires solving several hard computer science problems, something similar to a "cache invalidation" problem. He would have to keep a hash of every item in each STG window group to make sure existing items are updated and only new items are created, and vice versa. Or he can just start from scratch each time. It gets into the weeds quickly to try to implement this. He could potentially calculate a hash on the STGSync Bookmarks folder, or perhaps access a last sync'ed timestamp to know when he needs to update groups in STG from newly sync'ed bookmarks. The point is that this new implementation would require a private "STGSync BookMark Folder" which wouldn't be meant for any manual user interaction, which is how the current sync feature in #328 is implemented. In other words, the facility to backup window groups using firefox sync has been accomplished via bookmarks (which works around firefox sync data size limitations), |
Ah yes I didn't see that one! But how to import automatically from backup to new browser? |
Yes of course, I see that one. But I think this feature request is asking for automatic import from bookmark folders to groups. In other works automatic synchronization of window groups between browsers by using Firefox bookmarks to transfer the data. Computer 1 --> Browser 1 --> STG Window Groups >>>> Automatic STG BookMarks Folder Backup |
Automatic import is not yet possible due to technical reasons of the browser. |
What about a one click loading of some specific backup file from the drop down menu? The steps could be:
|
Automatically save the file is only possible in the download folder. And adding it to Dropbox is unlikely. |
Any savvy user could do a symlink or a small script to copy that automatically to Dropbox/Syncthing/etc |
I have a question about the backup to bookmark folder - it seems that when i close tabs from a tab group, they still remain in the backup and accumulate (i believe with a separator in between them). This might be the intended behavior for backups, but I tend to use this as a "sync" feature between browsers on different PCs. Therefore, it would be nice to have the option that the tabs are saved to the bookmarks "as is" - thereby replacing all the bookmarks in the previous backup. In other words, when i close a tab in the tab group, it will no longer appear in the backup, and this feature would operate as a true sync between browsers. Is this possible as an option? |
@lx0n2acl Yes, I thought to make this functionality customizable, but for some reason I didn’t)) in the near future I will make an option in the settings for the controllability of this behavior (bookmarks without tabs that are closed) |
Hi Drive4ik, sorry if I reopen this old discussion. |
I have been using Workona now. They just - finally - launched their plugin to Firefox. Works great so far, allows you to create groups much in the same manner as STG and automatically syncs across all your machines. I had some sync problems with it on Chrome, but now on Firefox they are gone. |
Hi @JackSlaterIV Bookmark sync already implemented and then you can change auto backup folder name manually create backup of all groups Then bookmarks will be synchronized between devices (if bookmark synchronization is enabled in the settings in the browser) |
@Drive4ik |
@JackSlaterIV |
Hello @Drive4ik Thanks for the extension. Firefox will never have, and shouldn't have MB sync limits for the reasons you mentioned in terms of sync start-complete delays. I do have a solution suggestion. A majority of the users are not having 3000+ tabs, and those who do should really look into using bookmarks, for the rest (and the majority of us) the following would work. Apply simple lookup of current tab numbers and use firefox sync if they are under a safe margin (let's say 500). If they are above the safe margin, show a little alert on the top of the simple tab group window that says "Tabs Exceed Firefox Sync limits". The sync issue is whats keeping me from adopting the plugin fully as others offer syncing. The groups really are most useful as a medium term management solution that is ideal for a desk to laptop workflow. Let me know if I can help with UX suggestions, I am mostly a designer. |
Hi @Drive4ik I see you're using Github Gists to implement the sync feature, an alternative solution to the problem indeed.
With all that, my estimate is that the average user can use the Sync without any major impacts. Anyways, this is the best extension out there for tab management! I hope you continue to work on it. If you think my suggestions combined are a good way to do the Mozilla Sync I can try to submit a PR for it. 1 seems bad, but 2+3 seems simpler and would solve the problem. |
Just discovered the addon and wow, I've been missing out! Integration with containers is amazing! |
@Shirkit I don't think you can split it into 8KB chunks since it's a key-value storage. Here's my proposal Storage quotasWe can have 512 items in the store. Each item can have 8192 bytes and the total storage is 102400 bytes. ProposalMy idea goes as follows:
{
"id": "integer",
"iconColor": "string",
"iconUrl": "string",
"iconViewType": "string",
"tabs": [
{
"id": "integer",
"url": "string",
"cookieStoreId": "string (optional)",
}
]
} I stripped the quintasan@demonbane:~$ ls -alh
-rwxr-xr-x 1 quintasan quintasan 11K Aug 1 21:57 [email protected]
-rwxr-xr-x 1 quintasan quintasan 8.4K Aug 1 22:12 [email protected]_stripped I removed all the extension preferences, title keys, and removed all the whitespace so my 24 tab group dump is 2.7K
By I believe that DownsidesCalculating the total storage is going to require N+1 calls to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea/getBytesInUse where N is the number of groups and the +1 comes from the Alternatively we could store everything under one key in which case we would be complicating the logic to update the tabs in groups. I belive that N+1 calls for storage calculation is the lesser problem. What do you think @Drive4ik ? |
@Quintasan your proposal makes more sense and it's simpler than mine in some regards. I did not want to change much the config file, so your idea is just better than mine in that regard. And one can adapt your solution to split into 2 or more items if a group exceeds the 8KB, which can be stored the values for it on the preferences item if such thing is really needed (I have one group with 60 tabs that reaches just over 7KB with your proposed solution without the |
I'm sorry to take this thread a bit of track, but has the UI described in the comment above changed? I've enabled "Allow access to bookmarks" (and replied "Allow" to the Firefox popup asking whether to allow access). I've selected "Other Bookmarks" as the folder, but I do not see anything being created there... There is no "Export groups to STG bookmakrs folder" checkbox underneath those settings... This is what my settings look like: |
@karypid it should be available when you right click on the extension (STG) icon. |
I have a few questions about this feature:
The way (1) is related to (2) is that I chose "Other bookmarks" in both my laptop and my desktop and I've ended up with two entries (one from each machine): I am not sure how to get STG to restore the state saved in the bookmarks. Is this the second option that reads "Reopen tabs with temporary containers in new"?: |
I feel like I've read this thread about 500 times. As @karypid noted, I enabled access to bookmarks and set the default bookmark location to "Other Bookmarks". After enabling backups (once a minute to test) and checking the Other Bookmarks folder, I now have multiple "Simple Tab Groups" folders for each computer. Is this the intended behavior? Because that doesn't really provide a way to keep the groups in sync. And I just can't tell if that is the shortcoming this thread keeps referring to at different stages of the implementation over time or if it just isn't working properly? (What I thought would happen is that there was one "Simple Tabs Groups" folder in Other Bookmarks and each browser would simply use the same folder. Can someone please clarify? And if this is the shortcoming, do you simply keep "re-importing" your groups into new groups and manually deleting the previous ones? It will also get progressively challenging to keep track of what folder is from which computer with them all named the same. Which is why I have the feeling this isn't actually working as intended. Signed, |
#291 (comment) |
Actually, I'm not sure if the developer is active right now. The previous commits are showing a "ghost author" (maybe just me) but seems like there's a problem with the account |
Thanks for the confirmation. Sadly, I'm stumbling across too may great add-on projects that seem to be dying a slow death. |
Yeah, it's not trivial to keep projects alive for long periods of time. This project seems to be maybe on the stage of security fixes only, we'll see on next big Firefox update with breaking changes if it will vanish. |
Unfortunately, I'm going to have to switch to a more important task - migrating to manifest v3. |
I never wanted to criticize anything, as I've learned that people have their lives, and we can clearly see (since you live in Ukraine) that it's well understood why the work on the addon has halted. The incredible only part here is you wanting to resume the work. At least now we know that, at least if this issue or other things in this addon does not get implemented, you'll at least try to keep it functional. Thank you for using your time working in this great addon. Sync is the only thing missing for me to optimize my workflow. |
I totally missed it: That's very good news. |
@Drive4ik Very sorry you have to deal with that every day. I actually took note that your profile mentioned Ukraine and wondered to myself if that was a factor. But I appreciate you taking the time to respond and for any work you are able to continue on this great add-on. The sync issue was a bit of a show stopper for my personal needs at the moment but I'm more than interested in re-evaluating if it comes about at some point. Thanks again for your contributions to improving the Firefox user experience! |
Ooh, I see some progress! Can't wait for cloud sync :D |
The automatic backup of the tab groups is a very useful feature, but currently it is only usable in a single PC configuration, due to the fact that the backups are saved in the Downloads folder. Would it be possible to add the same functionality using Firefox Sync?
The text was updated successfully, but these errors were encountered: