Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Tab Groups duplicating already restored tabs upon being clicked on after closing Firefox. #1196

Open
NylaTheWolf opened this issue Sep 7, 2024 · 1 comment

Comments

@NylaTheWolf
Copy link

NylaTheWolf commented Sep 7, 2024

Describe the bug
I had a strange bug that occurred when I closed the Firefox window I had open, instead of quitting the app directly like I usually do, in which my tabs duplicated (if I remember correctly) upon reopening. When I clicked on the STG extension, the tabs were duplicated again. I fixed this by opening a new Firefox window, closing the one with the duplicated tabs, and reinstalling STG.

I removed and readded the Simple Tab Groups extension and tried to restore my backup file, but it has been infinitely loading instead with the extension icon saying "Loading, please wait..." when I hover over it. I tried to restore a few times, some with "erase data before restoring" left on and once or twice where I turned it off. Both times gave the same issue. I removed and readded STG just now and tried again, and I am getting the same issue. I also can't close out of the "Loading" popup on the preferences page during the restore attempt and I have to refresh the page instead.

I had browser.sessionstore.restore_on_demand enabled when this bug was encountered.

To Reproduce:
Steps to reproduce the behavior:

  1. Close all Firefox windows.

  2. Reopen Firefox, presumably with browser.sessionstore.restore_on_demand enabled in about:config.

  3. Click on the STG icon.

  4. See error.

  5. Remove the Simple Tab Groups extension.

  6. Read the extension.

  7. Go to the Preferences page for the extension and go to the "Backup Your Simple Tab Groups" tab

  8. Click "Restore backup" and choose a backup file (mine was an automatically created one).

  9. See error.

Expected behavior
I expected my tabs to be reopened without duplication, and for STG to show the manage groups panel instead of trying to restore the tabs again in the same window.

For my second issue, I expected my STG data and groups to be restored.

Screenshots
N/A

Desktop (please complete the following information):

  • OS and version: [e.g. Windows]
  • Firefox version: [e.g. 63]
  • Simple Tab Groups version: [e.g. 3.0.8]

Additional context
I sent an email with my debug log, but I thought it was worth making a formal bug report.

Last night I had a bug after I closed my Firefox window (instead of quitting the app like I usually do where when I clicked on the STG extension, it didn't show the panel with the list of my groups but just reopened the already restored tabs (I believe Firefox restored them upon reopening), causing them to duplicate. It did thing even after I closed out Firefox and reopened it. I removed the extension, readded it, and decided to restore the auto backup from an hour earlier.

However, restoring the backup is not working and it is instead infinitely loading. I did this a few times, and two left "erase data before restoring" checked. I just removed and readded the extension, and I'm having the same problem.

It's worth mentioning that I think that Firefox automatically updated from 129.0.2 to 130.0 after I closed it the first time, due to how the backup file that was made an hour before the issues happened is in the folder "STG-backups-FF-129.0.2" and a new folder called "STG-backups-FF-130.0" was automatically created.

I doubt it's related but the reason I closed Firefox in the first place is because I experienced an issue where it wasn't letting me interact with any webpages but I could still switch tabs.

browser.sessionstore.restore_on_demand in Firefox's about:config was enabled when I closed Firefox and when I first encountered the bug, but I turned it off to prevent the duplicating tabs issue and because I saw someone suggest it as a solution in a bug report with a similar issue.

Edit: I managed to fix the issue with the session restore, but I wanted to include more information about the bug with restoring and duplicating tabs so that it could be looked into.

@NylaTheWolf
Copy link
Author

NylaTheWolf commented Sep 7, 2024

Update: I figured out what the issue with the session restore was: I went through my auto backup file and realized that there were blob images I had open that had ungodly long URLs. Upon replacing the URLs with something much shorter, I was able to restore my backup without any problems.

I don't know if I should close the issue myself, especially since I mentioned behavior like reopening tabs upon being clicked on that is still odd. I will edit my post to include that in the "describe the bug" section.

@NylaTheWolf NylaTheWolf changed the title Simple Tab Groups isn't restoring my backup and instead infinitely loading, even after removing and readding the extension. Simple Tab Groups duplicating tabs upon being clicked on after closing Firefox. Sep 7, 2024
@NylaTheWolf NylaTheWolf changed the title Simple Tab Groups duplicating tabs upon being clicked on after closing Firefox. Simple Tab Groups duplicating already restored tabs upon being clicked on after closing Firefox. Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant