Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catching and moving tabs with short domains correctly (x.com instead of box.com) #1188

Open
glciampaglia opened this issue Jul 31, 2024 · 0 comments

Comments

@glciampaglia
Copy link

glciampaglia commented Jul 31, 2024

Is your feature request related to a problem? Please describe.
The default way to enter regular expressions for catching and moving tabs causes issues with very short domains, like x.com. In that case, specifying the expressions as instructed in the tooltop (x\.com) ends up catching and moving tabs for ANY domains that end with the same suffix, like box.com, because of the trailing box.com in the domain.

Describe the solution you'd like
After some testing I found that if you specify the regex as \bx\.com instead of just x\.com (that is, pre-pending \b to match the word boundary at the beginning of a word) solves the issue.

So one possibility could be to always add \b to the expression before matching it; the user would not need to do anything.

Describe alternatives you've considered
Alternatively you could let the user decide but add a warning in the tooltip about short domains like x.com.

Additional context
In my case the problem was that I have a tab group for social media and I would like to catch and move only the tabs of X (old Twitter) to that particular group, not the tabs of Box.com (a cloud storage service which I use for work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant