Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gh-pages circleci config, was v1 and should now be managed by the master file #14

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

lacostej
Copy link
Member

This could also make #13 obsolete. Let's merge this one first and see how circle reacts.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what the master branch is, nor how CircleCI is supposed to run now

@lacostej
Copy link
Member Author

Not sure I understand what the master branch is, nor how CircleCI is supposed to run now

The master branch is the git master branch. It contains its own circleci configuration that is up to date with circleci requirements and contains [instructions to only build master](https://github.com/DragonBox/unities/blob/master/.circleci/config.yml#L52-L68].

Still I am seeing build failures (and notifications) on circleci every hour:

image

I am just trying to get rid of them. I suspect it is because the circleci v1 configuration in the gh-pages project is triggering the builds, overriding the master branch circleci configuration.

Copy link
Member

@niezbop niezbop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification

@lacostej lacostej merged commit c71ee2c into gh-pages Nov 18, 2019
@lacostej lacostej deleted the internal/remove_ghpages_branch_config_circleci branch November 18, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants