Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] u3d/install: refactor towards supporting a U3D_INSTALL_PATH env variable #287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lacostej
Copy link
Member

@lacostej lacostej commented Apr 19, 2018

Relates to #229

Lacks

  • documentation
  • unit tests
  • cleanup WRT to change in variable
  • decision WRT Mac target path support vs hardcoding '/'

@lacostej lacostej force-pushed the install_path branch 2 times, most recently from b37e08f to bccbec2 Compare April 23, 2018 14:55
@bdominguez
Copy link

@lacostej @niezbop How's this going? Now I pass the parameter "installation_path" that you have to indicate the path next to "Unity_VERSION".

I understand that this pull request improves this flow in terms of CI by only having to indicate the base path where all the directories of each version of the editor that would be built by u3d.

@niezbop
Copy link
Member

niezbop commented Nov 20, 2019

@bdominguez I think that this PR is in quite a poor shape right now. As said in #382 , the Unity .pkg installer does not support paths but only volumes, which is the reason for FIXME: we don't support target_path anymore in this PR.

We would need to take decisions WRT Mac target path support vs hardcoding '/'. And the installer have had a few modifications since this PR was opened, so we may have to rebase it and work on it some more. There are already some conflicts in the file.

I don't have much time to work on this soon but I'll try to take a look at what's possible to do when I can.

@bdominguez
Copy link

Ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants