Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify isn't showing compilation errors #362

Open
oddgames-david opened this issue Jul 4, 2019 · 2 comments
Open

Prettify isn't showing compilation errors #362

oddgames-david opened this issue Jul 4, 2019 · 2 comments
Labels

Comments

@oddgames-david
Copy link

I've not been able to get compiler errors showing for lines like this:

Assets\Code\CameraBase.cs(247,7): error CS0619: 'Component.camera' is obsolete: 'Property camera has been deprecated. Use GetComponent() instead. (UnityUpgradable)'

image

@niezbop
Copy link
Member

niezbop commented Jul 5, 2019

Hey @oddgames-david !

Thanks for the feedback.

This is an issue with regular expressions that I'm not sure I'll have the time to tackle super soon. In the meantime, if you want these errors to show right now, you can try to use your own set of rules! Let us know if you have trouble with this, and if you manage to fix the rules so that they show your errors, do open a pull request to bring your fix to the codebase, it would be much appreciated!

@niezbop niezbop added the bug label Jul 5, 2019
@oddgames-david
Copy link
Author

oddgames-david commented Sep 30, 2019

@niezbop Deleted the compiler_error and compiler_warning from COMPILE phase and added these to general (I deactivated warnings because almost impossible to remove warnings from projects with so many assets).

"compiler_error": {
        "active": true,
        "start_pattern": "(.*: error (CS....).*)",
        "type": "error"
      },

"compiler_warning": {
        "active": false,
        "start_pattern": "(.*: warning (CS....).*)",
        "type": "warning"
      },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants