Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest_stable turns out 2019.1.0f1 - but it's still in beta #357

Open
4 tasks done
Duobix opened this issue Apr 11, 2019 · 4 comments
Open
4 tasks done

latest_stable turns out 2019.1.0f1 - but it's still in beta #357

Duobix opened this issue Apr 11, 2019 · 4 comments
Labels

Comments

@Duobix
Copy link

Duobix commented Apr 11, 2019

Issue Checklist

  • I'm using the latest u3d version
  • I ran u3d --help
  • I read the README
  • I made sure that a similar issue doesn't exit

Issue Description

latest_stable returns a probably wrong version, that is - it's still a beta.
I ran "u3d install latest_stable -p Unity,Android,iOS", and got:
Version 'latest_stable' is 2019.1.0f1.
The latest stable version from what I know is now 2018.3.12f1, even 'u3d available'
returns a link to beta:
"Version 2019.1.0f1: https://beta.unity3d.com/download/5c52223b18d4/"

@lacostej
Copy link
Member

Ooops! Yes I found the issue. We fetch those from Unity's own json, but we map them to stable. It will be fixed in coming days. We'll probably add support for the older betas as well. Thanks for reporting!

@niezbop
Copy link
Member

niezbop commented Nov 13, 2019

Hey @Duobix !

I just took a look at your issue and we will not be addressing it in the upcoming release, ie soon. It would require a fairly large refactor for an issue that we feel is not critical.

For future reference, and if anyone wants to address this, the issue comes from the fact that the .json file that we get from the Hub offers several "channels", ie

{
    "official": [],
    "beta": []
}

But u3d does not parse those channels:

def fetch_from_json(url, pattern)
require 'json'
data = Utils.get_ssl(url)
JSON.parse(data).values.flatten.select { |b| pattern =~ b['downloadUrl'] }.map do |build|
[build['version'], pattern.match(build['downloadUrl'])[1]]
end.to_h
end

However, as said earlier, the underlying model is simply a dictionary of 'version' => 'url' which does not support the idea of channel introduced in the hub, and would need to be changed.

@niezbop niezbop added the bug label Nov 13, 2019
@M1kep
Copy link

M1kep commented Dec 4, 2019

@niezbop Would this cause u3d available on Linux to only go up to 2019.1.0f2?

@niezbop
Copy link
Member

niezbop commented Dec 4, 2019

@M1kep It doesn't!

Note that u3d available works locally when fetching the versions myself.

$ u3d available -o linux --force --no-central
...
Version 2018.3.0f2: https://beta.unity3d.com/download/6e9a27477296/
Version 2018.4.13f1: https://download.unity3d.com/download_unity/497f083a43af/
Version 2019.1.0f2: http://beta.unity3d.com/download/292b93d75a2c/
Version 2019.2.14f1: https://download.unity3d.com/download_unity/49dd4e9fa428/
Version 2019.3.0f1: https://beta.unity3d.com/download/ffacea4b84e7/
Version 2020.1.0a14: https://beta.unity3d.com/download/2a3307d3869b/

So the issue is probably that the central cache hasn't updated yet! However if you run the command I just ran, it will update your local versions cache so you'll be able to download and install whichever version you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants