GraphBLAS: Override GrBJITPackageGenerator_DIR when cross-compiling.
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, this is ok |
|
Turns out this might have been a configuration issue or a bug in CMake. Might still be worth taking this as a workaround... |
Fixes DrTimothyAldenDavis#729. Thanks to @jschueller for tracking this down.
|
Looks OK to me. |
DrTimothyAldenDavis
merged commit d88745b
into
DrTimothyAldenDavis:dev2
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #729.
Thanks to @jschueller for tracking this down.
@jschueller: Is that the change that you were proposing? Does it work with that change for you?