Fix *_USE_OPENMP, *_HAS_OPENMP, *_USE_CUDA, and *_HAS_CUDA #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is needed so that the libraries "see" each other if they are installed at a path that is not in the default LIBRARY_PATH.
CMake: Use `@*_HAS_OPENMP@` in conditions in import target files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #622 .
If
SUITESPARSE_USE_OPENMPis OFF, this forces all*_USE_OPENMPoptions to beOFF.Likewise if
SUITESPARSE_USE_CUDAis OFF, this forces all*_USE_CUDAoptions to beOFF.Added
SUITESPARSE_CONFIG_USE_OPENMPoption, sinceSuiteSparse_configcan optionally use OpenMP.Also fixed a bug in ParU when OpenMP was disabled, to allow it to compile without OpenMP. ParU is fundamentally a parallel package, so OpenMP is highly recommended for ParU ... but it still can be compiled without it. If using OpenMP, ParU requires OpenMP 4.5 or later.