Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAGraph: Link to OpenMP::OpenMP_C target #452

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Oct 20, 2023

Building LAGraph with OpenMP currently fails if the OpenMP headers are installed in a non-default location.
E.g.: https://github.com/DrTimothyAldenDavis/SuiteSparse/actions/runs/6578211130/job/17871438146#step:7:6548

  [  0%] Building C object src/CMakeFiles/lagraph.dir/algorithm/LAGr_Betweenness.c.o
  In file included from /Users/runner/work/SuiteSparse/SuiteSparse/LAGraph/src/algorithm/LAGr_Betweenness.c:79:
  In file included from /Users/runner/work/SuiteSparse/SuiteSparse/LAGraph/src/utility/LG_internal.h:30:
  /Users/runner/work/SuiteSparse/SuiteSparse/LAGraph/include/LAGraph.h:51:14: fatal error: 'omp.h' file not found
      #include <omp.h>
               ^~~~~~~
  1 error generated.

The proposed change hopefully fixes that by linking to the imported CMake target OpenMP::OpenMP_C which should be providing all necessary information.

(Again, it would be easier to check whether this works if #450 was merged.)

@DrTimothyAldenDavis
Copy link
Owner

Thanks! I've merged #450, and I'll merge this one now.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit e9683b8 into DrTimothyAldenDavis:dev2 Oct 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants