Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPEXpy: invalid memory write by strcpy() #847

Closed
svillemot opened this issue Jul 5, 2024 · 1 comment
Closed

SPEXpy: invalid memory write by strcpy() #847

svillemot opened this issue Jul 5, 2024 · 1 comment

Comments

@svillemot
Copy link
Contributor

On this line:

SuiteSparse/SPEX/Python/SPEXpy/Source/spex_python_connect.c

Line 146 in 26ababc

sol_void[i] = (void*) malloc (sizeStr*sizeof(char));

The buffer allocated is not large enough. One more byte needs to be allocated for the null terminal.
mmuetzel added a commit to mmuetzel/SuiteSparse that referenced this issue Jul 7, 2024
@mmuetzel
SPEX: Allocate enough memory for NULL terminator.
f3c5a9f 
Fixes DrTimothyAldenDavis#847.

Thank you to Sébastien Villemot for pointing out the fix.
mmuetzel added a commit to mmuetzel/SuiteSparse that referenced this issue Jul 7, 2024
@mmuetzel
SPEX: Allocate enough memory for NULL terminator.
09d7467 
Fixes DrTimothyAldenDavis#847.

Thank you to Sébastien Villemot for pointing out the fix.
@mmuetzel mmuetzel mentioned this issue Jul 7, 2024
Merged
@mmuetzel
Copy link
Contributor

mmuetzel commented Jul 7, 2024

Thank you for reporting this issue.

I opened #851 with the fix you pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svillemot @mmuetzel