Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with CMake < 3.24 and openMP fails #669

Closed
MarDiehl opened this issue Jan 1, 2024 · 4 comments
Closed

Build with CMake < 3.24 and openMP fails #669

MarDiehl opened this issue Jan 1, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@MarDiehl
Copy link

MarDiehl commented Jan 1, 2024

Describe the bug
Building with CMake < 3.24 fails because

find_package ( OpenMP GLOBAL )

in SuiteSparse_config/CMakeLists.txt which has cmake_minimum_required ( VERSION 3.22 ) but according to https://cmake.org/cmake/help/latest/command/find_package.html 3.24 is required.

3.24 is about 1.5 years old (https://www.kitware.com/cmake-3-24-0-is-available-for-download/)

Screenshots

CMake Error at SuiteSparse_config/CMakeLists.txt:73 (find_package):
  find_package called with invalid argument "GLOBAL"

Desktop (please complete the following information):
linux-pkgs-dbg-ftn-interfaces configuration on GitLab CI of PETSc (https://gitlab.com/petsc/petsc/-/jobs/5840470517)

Additional context
https://gitlab.com/petsc/petsc/-/merge_requests

@mmuetzel
Copy link
Contributor

mmuetzel commented Jan 1, 2024

Thanks for reporting.
#670 should work around that issue with older CMake versions.

@DrTimothyAldenDavis DrTimothyAldenDavis added the bug Something isn't working label Jan 1, 2024
@DrTimothyAldenDavis
Copy link
Owner

Would it be helpful to post a SuiteSparse 7.5.0.betaX release with this update?

@DrTimothyAldenDavis
Copy link
Owner

I've posted a 7.5.0.beta3 with this fix: https://github.com/DrTimothyAldenDavis/SuiteSparse/releases/tag/v7.5.0.beta3

@DrTimothyAldenDavis
Copy link
Owner

Fixed in 7.5.0 (to be released today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants