Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static linker flags wrong in LAGraph.pc #656

Closed
mmuetzel opened this issue Dec 30, 2023 · 4 comments
Closed

Static linker flags wrong in LAGraph.pc #656

mmuetzel opened this issue Dec 30, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mmuetzel
Copy link
Contributor

The static linker flags are wrong in the pkg-config file generated by LAGraph when building with the root Makefile (or as a stand-alone project). They contain something that looks like a CMake target name of GraphBLAS verbatim.
The flags in that file look ok when the file is generated with the root CMakeLists.txt.

I'm looking into the cause and a possible fix currently.

@mmuetzel
Copy link
Contributor Author

Looking at the pkg-config files in more detail revealed a couple more issues.
I opened some PRs that should hopefully fix them: #660, #661

I'll wait if they get accepted before looking into adding CI tests for them.

@mmuetzel
Copy link
Contributor Author

I opened #666 that adds steps to the CI which might have caught those issues earlier.

@DrTimothyAldenDavis
Copy link
Owner

I've posted a 7.5.0.beta3 with this fix: https://github.com/DrTimothyAldenDavis/SuiteSparse/releases/tag/v7.5.0.beta3 .

Are these issues fixed now?

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Jan 2, 2024

The CI step that builds the example using autotools isn't failing. It would have failed if this still was an issue.

So, this particular issue should be fixed now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants