Fish integration doesn't work

[ron-wolf]

Type: Bug

Behaviour

Expected vs. Actual

Expected

When I open a new terminal in a WSL folder with a virtual environment, it activates the environment.

Actual

This works in other shells, but not in Fish.

Steps to reproduce:

1. Clone a repo that uses venv into WSL with fish set as the shell configuration. (Did this using GCM into fedora-remix via WSL2 on Windows 10 21H2 Build 19044.)
2. Run the command Terminal: Create New Terminal.

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.10.6
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
• Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

source /home/nil/proj/hatchways-backend/venv/bin/activate.fish
Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
nil@Ron-Wolf-Framework-Laptop ~/p/hatchways-backend (dev)> source venv/bin/activate.fish
(venv) nil@Ron-Wolf-Framework-Laptop ~/p/hatchways-backend (dev)>

User Settings

languageServer: "Pylance"

Extension version: 1.0.4
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:03:37.738Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2

System Info

Item	Value
CPUs	11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	undefined
Memory (System)	15.79GB (2.32GB free)
Process Argv	--crash-reporter-id 9498ae81-8173-4a7c-9701-b32185a5a055
Screen Reader	no
VM	0%

Item	Value
Remote	WSL: fedoraremix
OS	Linux x64 5.10.102.1-microsoft-standard-WSL2
CPUs	11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)
Memory (System)	12.31GB (10.97GB free)
VM	0%

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30557515
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
fc301958:30573243

[ron-wolf]

Screen recording

[ron-wolf]

Relevant code

I believe the following portion of this repository's codebase may be relevant to the issue:

vscode-python-manager/src/client/common/terminal/activator/base.ts

Lines 31 to 36 in 38709f2

	for (const command of activationCommands) {
	terminal.show(options?.preserveFocus);
	terminal.sendText(command);
	await this.waitForCommandToProcess(terminalShellType);
	activated = true;
	}

[DonJayamanne]

Thanks for filing this issue, i'll take a look at this.