Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pretty tabComplete #28

Closed
wants to merge 1 commit into from
Closed

Conversation

Soul-KRT
Copy link

@Soul-KRT Soul-KRT commented Aug 17, 2023

Changes Made

  • add CommandManager to PartyCommand constructor
  • add some methods in CommandManager
  • add pretty tabComplete to all commands

Reason for Changes

  • tabComplete was so ugly and don't work

@Dominik48N
Copy link
Owner

Thank you for the contribution!
There are many changes in the pull request that do not belong to the Complete tab.
The multi-proxy support would also no longer be 100% guaranteed with this tab-complete. Only the player names of the players on the same proxy server are suggested.

However, the tab complete would take too long with larger numbers of players to extract and filter all players from Redis.
I think such a tab complete for all players in the network would also be disadvantageous for vanish players on some servers, which is why if you were to add something like this, an option in the config would be appropriate.

Thanks for the contribution anyway, but I'll close the pull request.

@Dominik48N Dominik48N closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants