fix: avoid incorrect warning about broken localizations in cogs #1133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cogs copy all command objects at instantiation (for applying cog-wide parameters), which ends up calling
Option.name_localizations.__eq__
further down the line; at that point,LocalizationValue
s haven't been linked yet, which results in warnings being thrown incorrectly.This PR fixes the comparison to bypass the property that's responsible for the warning in this particular case.
(at this point, localization probably deserves a full refactor, but that's a topic for another day)
Checklist
pdm lint
pdm pyright