Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor/Unsure] Popular/New Games appearing random order on refresh #95

Open
Quarris opened this issue Jun 30, 2020 · 2 comments
Open

[Minor/Unsure] Popular/New Games appearing random order on refresh #95

Quarris opened this issue Jun 30, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@Quarris
Copy link

Quarris commented Jun 30, 2020

Description
Refreshing the Diluv Homepage causes the game icons for Popular/New games to appear in random order. This is might be intentional or not thought about, however in my (one time) experience I wanted to check out the games one by one so I clicked on the first one and when I went back and attempted to click on the second icon I accidentally clicked on the same icon. It's a very minor issue (if even an issue) but it's something.

Reproduction Steps

  1. Open the page.
    b) Refresh a couple of times.

Expected behavior
I expected the game icons to stay in the same place (probably in alphabetical order

Screenshots
https://gyazo.com/67ba37b5005e14be1e4650f968a05c4a

Platform:

  • OS: Win10
  • Browser: Chrome
  • Device: Desktop
@jaredlll08 jaredlll08 transferred this issue from Diluv/Diluv-Website Jun 30, 2020
@jaredlll08
Copy link
Member

I believe this is caused by the staging data having the "createdAt" date being the same for each game, so the sorting result isn't the same. Moved to the API repository though.

@Darkhax Darkhax added the bug Something isn't working label Jul 3, 2020
@FalseHonesty
Copy link

I believe that Jared is correct, it looks like when a query is ordered by a column that has duplicate entries, the DB implementation is free to return them in whatever order they specify. It looks like the best solution would be to sort by a secondary column, such as the name column, here. I'll look into setting these repositories up and PR'ing this, just leaving this here for feedback in case someone has something to say :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants