Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe renaming #581

Open
Hpn4 opened this issue Oct 2, 2024 · 3 comments
Open

Pipe renaming #581

Hpn4 opened this issue Oct 2, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request refacto Anything that needs refactoring

Comments

@Hpn4
Copy link
Collaborator

Hpn4 commented Oct 2, 2024

  • Rename batch_size to frame_packet (michael)
  • Rename insert_wait_frames to insert_wait_frame_packet
  • Most of the function (cuda kernels, wrappers, ...) in pipe takes an input buffer and an output buffer. Rename the name of these buffers to output and input. The best will be to have output as first argument and input as second argument in order to unify with CUDA naming convention.
@Hpn4 Hpn4 added enhancement New feature or request refacto Anything that needs refactoring labels Oct 2, 2024
@simon-riou
Copy link
Collaborator

simon-riou commented Oct 10, 2024

Most of the function (cuda kernels, wrappers, ...) in pipe takes an input buffer and an output buffer. Rename the name of these buffers to output and input. The best will be to have output as first argument and input as second argument in order to unify with CUDA naming convention.

  • apply_mask.cu
  • composite.cu
  • convolution.cu
  • fft2.cu
  • frame_reshape.cu
  • input_filter.cu
  • percentile.cu
  • rgb.cu
  • stft.c
  • texture_update.cu
  • tools_compute.cu
  • tools_hsv.cu
  • transforms.cu
  • chart.cu
  • contrast_correction.cu
  • fft1.cu
  • filter2D.cu
  • hsv.cu
  • map.cu
  • reduce.cu
  • shift_corners.cu
  • test_reduce.cu (What is the purpose of this file ?)
  • tools.cu
  • tools_conversion.cu
  • tools_unwrap.cu
  • unpack.cu

@simon-riou
Copy link
Collaborator

simon-riou commented Oct 11, 2024

In shift_corners, these overloaded functions are never used:

void shift_corners(cuComplex* output,
                   const cuComplex* input,
                   const uint batch_size,
                   const uint size_x,
                   const uint size_y,
                   const cudaStream_t stream);

Any particular reason, or we can simply remove them ?

@simon-riou
Copy link
Collaborator

I noticed that there are missing tests for some CUDA fonctions, or some are not run in testsuite (might be expected, for example test_reduce.cc), or some doesn't work ... Might create an issue about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refacto Anything that needs refactoring
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants