Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a base class for all phantom camera and merge the EHoloGrabber #564

Open
Hpn4 opened this issue Oct 1, 2024 · 1 comment
Open

Create a base class for all phantom camera and merge the EHoloGrabber #564

Hpn4 opened this issue Oct 1, 2024 · 1 comment
Assignees
@GustaveHerve
Labels
refacto Anything that needs refactoring

Comments

@Hpn4
Copy link
Collaborator

Hpn4 commented Oct 1, 2024

The CameraPhantom class is defined in 4 files, the inerface is exactly the same. Also the EHoloSubGrabber is present and the same for the 4 phantom camera.

A way to do it will be to have a base class for CameraPhantom and EHoloGrabber and then specialize it for each camera.
@Hpn4 Hpn4 added the refacto Anything that needs refactoring label Oct 1, 2024
@GustaveHerve GustaveHerve self-assigned this Oct 1, 2024
@Baschtien
Copy link
Collaborator

Baschtien commented Oct 1, 2024 •
edited
Loading

Maybe use this opportunity to move code from the headers to the actual code files ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GustaveHerve GustaveHerve

Labels
refacto Anything that needs refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hpn4 @GustaveHerve @Baschtien