Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant performance loss after reloading compute setting when auto contrast is on #459

Open
NoeTopeza opened this issue Jul 16, 2024 · 5 comments
Assignees
Labels
non-urgent non-urgent issues question Further information is requested

Comments

@NoeTopeza
Copy link
Collaborator

Changing/reloading compute settings or camera decrease significantly the applications performances (observable on the speed at which the input queue empties itself).
Functions MainWindow::reload_ini(const std::string& filename) and MainWindow::change_camera need to be examined.

@NoeTopeza NoeTopeza added bug Something isn't working urgent Must be fixed in priority labels Jul 16, 2024
@NoeTopeza
Copy link
Collaborator Author

Observation: the quantity of memory taken by the app appear to increase by a fixed/proportional amount when changing/reloading.

@NoeTopeza
Copy link
Collaborator Author

NoeTopeza commented Jul 16, 2024

Changing batchsize (reducing it) will increase the amount of memory the app takes.
Increasing it back doesn't shrink the memory used.

After further research, this bug isn't linked to the current issue and is much older (pre 12.10 !)

@NoeTopeza
Copy link
Collaborator Author

Also triggers when saving advanced settings

@NoeTopeza
Copy link
Collaborator Author

it's auto contrast
Activating it (even by deactivating it immediately afterwards) causes a loss of performance the next time the compute settings are reloaded, resolvable by relaunching the application after deactivating it.

@NoeTopeza NoeTopeza changed the title Performance loss when executing MainWindow::reload_ini(const std::string& filename) and MainWindow::change_camera Significant performance loss after reloading compute setting when auto contrast is on Jul 26, 2024
@NoeTopeza NoeTopeza pinned this issue Aug 5, 2024
@simon-riou
Copy link
Collaborator

auto_contrast_performance

It might have been fixed since then with an other issue, if not, I cannot see a major performance loss while playing with auto contrast on/off, nor saving advanced settings. In the picture linked, I cannot say there is any performance loss, nor memory leaks with the contrast, (In the picture, 1 is auto contrast on, 2 is auto contrast off) I only noticed that turning auto contrast off doesn't give back the memory, i don't have an explanation yet.

@simon-riou simon-riou self-assigned this Sep 23, 2024
@simon-riou simon-riou removed the urgent Must be fixed in priority label Sep 23, 2024
@TitouanGragnic TitouanGragnic added question Further information is requested non-urgent non-urgent issues and removed bug Something isn't working labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-urgent non-urgent issues question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants