Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request a rating system #873

Closed
kokkeng1 opened this issue Oct 23, 2023 · 6 comments
Closed

Request a rating system #873

kokkeng1 opened this issue Oct 23, 2023 · 6 comments

Comments

@kokkeng1
Copy link

kokkeng1 commented Oct 23, 2023

I checked it on the discussion board, but it's too old an issue

Please describe your suggestion, and the problem it'd solve.

First of all, thank you for developing a good app.
I saw a comment saying that the rating system has low priority and should be managed with tags.
But it's very strange that the Content Manager app doesn't have a scoring system. I want you to know that there is a demand to distinguish whether this was good or not by horoscope because a person's memory is limited.
It is very cumbersome to modify the tag you suggested before. Since the app doesn't have a tag preset, I always have to add an emoji to modify it.

Additional context
I request modify the score with a click in the Archive Overview menu.

@Difegue
Copy link
Owner

Difegue commented Oct 23, 2023

👋 I still maintain this can and should be handled thru a tag instead of spinning off yet another DB field, as it makes sorting by rating "just work" with the current design.

A rating control could be added to the edit UI to quickly add/update/remove a matching rating: tag, I suppose.

@alok5050
Copy link

Hey, I am new to this and would like to contribute. Do you have any pointers on how to get started with this issue?

@Difegue
Copy link
Owner

Difegue commented Oct 23, 2023

Sure! Thanks for stepping up 🙏 I believe this can be done thru frontend only.
You can use Codespaces to spin up a development version of the app, and just upload any random pdf or zip with one image in it to get an entry you can add metadata to.

You can look at https://github.com/Difegue/LANraragi/blob/dev/templates/edit.html.tt2 and https://github.com/Difegue/LANraragi/blob/dev/public/js/edit.js for the HTML/JS code used by the edit metadata page.

Tags in LRR are in a simple comma-delimited format, so implementing this should be as easy as adding a rating control that when interacted with, adds a rating:⭐⭐⭐⭐, tag to the textfield.
If a rating tag is already present, it should update it with the matching star count.

I suppose the rating should go from 1 to 5 stars, and selecting 0 stars should remove the tag from the textfield.

@chu-shen
Copy link

chu-shen commented Nov 1, 2023

Below is an example that works for me by editing the UI and using plugins

chrome_oD0xFBmmrE

But there is still some questions

  • Currently, updates are not supported.
  • I also added a Comment tag. Since all tags in LRR are stored in the "Tag" field and separated by commas, Comment tag cannot contain commas. I'm not sure if this approach is suitable...

As an aside, if you use this new react-based PWA client, you may like this Rating&Comment

@Difegue
Copy link
Owner

Difegue commented Dec 16, 2023

👋 Just popping in to mention a comment field would be added by #588.

In case anyone wants to work on that...

@Difegue
Copy link
Owner

Difegue commented Oct 13, 2024

Implemented in #1079.

@Difegue Difegue closed this as completed Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants