Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicates from Marvel CBRO with Events part 5 #193

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rad96
Copy link
Contributor

@rad96 rad96 commented Sep 8, 2024

Removed issues which intersects inside various events.

@DieselTech
Copy link
Owner

Can you explain the reasoning behind the removals? The list is in question is a "with events" type of list to begin with, so why would event based issues be removed?

@rad96
Copy link
Contributor Author

rad96 commented Oct 9, 2024

Can you explain the reasoning behind the removals? The list is in question is a "with events" type of list to begin with, so why would event based issues be removed?

Komga does not allow CBL match till duplicates are resolved

@DieselTech
Copy link
Owner

Ah okay I see, it is about removing duplicates like the title says. I got confused for a second by the first post that just says: Removed issues which intersects inside various events.

@rad96
Copy link
Contributor Author

rad96 commented Oct 9, 2024

I don't see any statement about shall they be present in list or not
If they should then you can close all duplicate related PRs and I will just go along with my fork when they will be removed

@rad96
Copy link
Contributor Author

rad96 commented Oct 9, 2024

This is old one, I didn't know much about comics back then

@rad96
Copy link
Contributor Author

rad96 commented Oct 9, 2024

Will make separate PR with spider-girl fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants