This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Move the basic parameter model components to MXB #1537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this is good as a first pass for getting things generic but I think there's some extra things we should think about (feel free to make new issues or solve here):
- I dislike that we need to have a subclass to basically just fill in the defaults. I feel like you should be able to do something like the way we fill in the devices using the BlueAPI context where we also fill in these constants from the context (which picks them out the appropriate
dodal.beamline
) - The deploy script currently gives us a
dodal
deployment in the expected place. Should we now do the same formx_bluesky
? - We also need to update our release docs/script to include doing an
mx_bluesky
release now
|
dperl-dls
added a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 942706a.
DominicOram
pushed a commit
that referenced
this pull request
Aug 21, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…hyperion#1537) * add mxb workspace * move parameter components to mx-bluesky * remove dependency on semver * update mxb pin
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DiamondLightSource/mx-bluesky#162
Moves the parameted model base components to mx-bluesky, re-adds the default values here in hyperion
Link to MXB PR (if required): #163
To test: