This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Removed some references to ophyd #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dperl-dls
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
nice! Maybe a different issue but reading this made me notice that I think we should be tagging the statuses from fixtures with the test name from the request
edit: oh, that won't be possible anymore with AsyncStatus, maybe we should add that when we add the DoneAsyncStatus or whatever. And it isn't even possible with NullStatus because it inherits from StatusBase rather than Status :/
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few references to ophyd. Most of what's left should be those needed for devices that are still ophyd or
NullStatus, which will need to think of a clean replacement forTo test: