Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

(#842) Fix ispyb activation so that messages can be logged from pin tip detection #1502

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jul 30, 2024

Fixes #824

Link to dodal PR (if required): N/A
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. ispyb comments should now appear when the pin tip is too short or too long
  2. Tests pass

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtuck99 rtuck99 merged commit af118c6 into main Aug 6, 2024
22 checks passed
@rtuck99 rtuck99 deleted the 824_fix_pin_too_long_short_message branch August 6, 2024 10:20
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signify on synchweb pin too long/short due to pin detect
2 participants