Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Rename ispyb credentials file #1223

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Rename ispyb credentials file #1223

merged 1 commit into from
Mar 7, 2024

Conversation

DominicOram
Copy link
Collaborator

Fixes #865

To test:

  1. Confirm test_ispyb_get_comment_from_collection_correctly still passes
  2. Other ispyb system tests should also pass but are failing on main. Won't fix as the soon to be merged ispyb refactor is going to change it all anyway

dperl-dls
dperl-dls approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@DominicOram DominicOram merged commit 3212c7a into main Mar 7, 2024
22 checks passed
@DominicOram DominicOram deleted the 865_rename_ispyb_config branch March 7, 2024 11:59
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
@DominicOram
Merge pull request DiamondLightSource/hyperion#1223 from DiamondLight…
f48aecf 
…Source/865_rename_ispyb_config

Rename ispyb credentials file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dperl-dls dperl-dls dperl-dls approved these changes

@rtuck99 rtuck99 Awaiting requested review from rtuck99

@olliesilvester olliesilvester Awaiting requested review from olliesilvester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename ispyb config file
2 participants
@DominicOram @dperl-dls