Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Relative move in pin tip center should use setpoint #963

Closed
DominicOram opened this issue Nov 8, 2023 · 1 comment
Closed

Relative move in pin tip center should use setpoint #963

DominicOram opened this issue Nov 8, 2023 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Collaborator

In converting the smargon to ophyd-async we had some issues creating a simulated motor that sets the readback to the setpoint. This made testing the relative move in the pin tip centring plan hard. We should do the relative move from the setpoint rather than the readback, this will simplify the tests and has the same behaviour in prod.

Acceptance Criteria

  • The relative move in the pin tip center plan will move based on setpoint rather than readback
  • Tests still pass
@DominicOram DominicOram added the good first issue Good for newcomers label Nov 8, 2023
@rtuck99 rtuck99 self-assigned this Nov 9, 2023
@DominicOram
Copy link
Collaborator Author

Closing as it's too messy, we should just do bluesky/ophyd-async#57 instead

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

2 participants