Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

remove dataclasses_json (and maybe dataclasses) #815

Closed
dperl-dls opened this issue Jul 19, 2023 · 0 comments · Fixed by #817
Closed

remove dataclasses_json (and maybe dataclasses) #815

dperl-dls opened this issue Jul 19, 2023 · 0 comments · Fixed by #817

Comments

@dperl-dls
Copy link
Collaborator

currently we have a mixture of pydantic models with some legacy dataclasses_json here and there (notably __main__.py) - we should streamline this and remove the dependency on dataclasses-json. this should basically just work as is by changing them to pydantic.dataclasses, and possibly changing some.to_json()to.json()`

maybe we can also change other basic dataclasses but that's less important as they are in the standard lib and not a dependency

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant