Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Stub offset motion #794

Closed
DominicOram opened this issue Jul 13, 2023 · 1 comment · Fixed by #969
Closed

Stub offset motion #794

DominicOram opened this issue Jul 13, 2023 · 1 comment · Fixed by #969
Assignees
@DominicOram
Labels
Other UDC Bits The small bits outside main scans that are required

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Jul 13, 2023 •
edited
Loading

The smargon has an internal calibration to keep the tip in the centre of rotation for all 3 axes. We need the ability to change the offsets such that where we currently are is the centre
@DominicOram DominicOram added the Other UDC Bits The small bits outside main scans that are required label Jul 13, 2023
@DominicOram DominicOram self-assigned this Oct 12, 2023
@DominicOram
Copy link
Collaborator Author

We need to:

  1. Write to BL03I-MO-SGON-01:CENTER_CS.PROC to centre the offsets once we're at centre.
  2. Write to BL03I-MO-SGON-01:SET_STUBS_TO_RL.PROC before robot load
  3. Write to BL03I-MO-SGON-01:RESTORE_POS_STUBS.PROC if we ever crash

For now we can assume that GDA handles 2/3 so we need to only do 1

DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Oct 12, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Add stub offsets to smargon
ea9fa67
DominicOram added a commit that referenced this issue Oct 12, 2023
@DominicOram
(#794) Recenter smargon when xray center found
b22d319
This was referenced Oct 12, 2023
Closed
Closed
DominicOram added a commit that referenced this issue Oct 13, 2023
@DominicOram
(#794) Pin dodal
9870ab0
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Oct 30, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Convert smargon to use ophyd-async
dea5b35
DominicOram added a commit that referenced this issue Oct 30, 2023
@DominicOram
(#794) Use ophyd-async smargon
32f2859
DominicOram added a commit that referenced this issue Nov 1, 2023
@DominicOram
(#794) Fix unit tests around new smargon
c963c82
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 9, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Add stub offsets to smargon
7429e3d
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 9, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Fix race condition in stub offsets
3d7d056
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 9, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Tidy up stub offsets and add tests
f5e7954
@DominicOram DominicOram mentioned this issue Nov 9, 2023
Merged
2 tasks
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Nov 9, 2023
@DominicOram
(DiamondLightSource/hyperion#794) Add more smargon tests
b8f9eab
DominicOram added a commit that referenced this issue Nov 9, 2023
@DominicOram
(#794) Recenter smargon when xray center found
ebc0169
DominicOram added a commit that referenced this issue Nov 9, 2023
@DominicOram
(#794) Center stub offsets after an XRC also adds tests
bb6a762
@DominicOram DominicOram mentioned this issue Nov 9, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
Other UDC Bits The small bits outside main scans that are required
Projects
Hyperion
Archived in project
Milestone
No milestone
1 participant
@DominicOram