Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Tidy up eiger when pin too long #791

Closed
DominicOram opened this issue Jul 11, 2023 · 1 comment · Fixed by #805
Closed

Tidy up eiger when pin too long #791

DominicOram opened this issue Jul 11, 2023 · 1 comment · Fixed by #805
Assignees
@DominicOram
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

When the scan is invalid we do not correctly tidy up the eiger as it's asynchronously arming in the background. This may be fixed by #765, we should test this
@DominicOram DominicOram mentioned this issue Jul 11, 2023
Closed
@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Jul 11, 2023
@DominicOram
Copy link
Collaborator Author

Testing #765 on the beamline showed this doesn't quite work as we get an error waiting for the Eiger to get all the images. We should implement a stop that doesn't wait

DominicOram added a commit that referenced this issue Jul 15, 2023
@DominicOram
(#788 & #791) Eiger disarmed and correct error returned on plan excep…
0b88106 
…tion
@DominicOram DominicOram mentioned this issue Jul 15, 2023
Merged
@DominicOram DominicOram self-assigned this Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
needed_for_release Issues that must be complete before the next release
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that eiger cleans up properly on error DiamondLightSource/hyperion
1 participant
@DominicOram