Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Issues with v5 (part 2) #781

Closed
DominicOram opened this issue Jul 6, 2023 · 1 comment · Fixed by #803
Closed

Issues with v5 (part 2) #781

DominicOram opened this issue Jul 6, 2023 · 1 comment · Fixed by #803
Assignees
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

  • GridAxis on the GridParams needed reinitialising e.g. hacky code:
    out_parameters.x_axis = GridAxis(
        out_parameters.x_start, out_parameters.x_step_size, out_parameters.x_steps
    )
    out_parameters.y_axis = GridAxis(
        out_parameters.y1_start, out_parameters.y_step_size, out_parameters.y_steps
    )
    out_parameters.z_axis = GridAxis(
        out_parameters.z2_start, out_parameters.z_step_size, out_parameters.z_steps
    )
  • Snapshots not changing e.g. still using the same snapshot as previous sample. Issue was the OavSnapshotCallback is holding state as class variables and so keeping it between runs
  • Error in logs, doesn't seem to be causing issues:
[2023-07-06 15:44:04,951] ophyd status ERROR: An error was raised on a background thread while running the callback <function PinTipDetect.trigger.<locals>.set_to_default_and_finish at 0x7f9e446bf130>(Status(obj=PinTipDetect(prefix='BL03I-DI-OAV-01:MXSC:', name='oav_mxsc_pin_tip', parent='oav_mxsc', read_attrs=['tip_x', 'tip_y', 'triggered_tip', 'validity_timeout'], configuration_attrs=[]), done=True, success=False)).
Traceback (most recent call last):
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/dodal/src/dodal/devices/areadetector/plugins/MXSC.py", line 35, in set_to_default_and_finish
    subscription_status.set_finished()
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/artemis/.venv/lib/python3.10/site-packages/ophyd/status.py", line 742, in set_finished
    super().set_finished()
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/artemis/.venv/lib/python3.10/site-packages/ophyd/status.py", line 337, in set_finished
    raise InvalidState(
ophyd.utils.errors.InvalidState: Either set_finished() or set_exception() has already been called on SubscriptionStatus(device=oav_mxsc_pin_tip_tip_x, done=True, success=True)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/artemis/.venv/lib/python3.10/site-packages/ophyd/status.py", line 268, in _run_callbacks
    cb(self)
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/dodal/src/dodal/devices/areadetector/plugins/MXSC.py", line 37, in set_to_default_and_finish
    subscription_status.set_exception(e)
  File "/dls_sw/i03/software/bluesky/artemis_v5.1.0/artemis/.venv/lib/python3.10/site-packages/ophyd/status.py", line 317, in set_exception
    raise InvalidState(
ophyd.utils.errors.InvalidState: Either set_finished() or set_exception() has already been called on SubscriptionStatus(device=oav_mxsc_pin_tip_tip_x, done=True, success=True)
@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Jul 14, 2023
@DominicOram
Copy link
Collaborator Author

Final point addressed in #789

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needed_for_release Issues that must be complete before the next release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant