Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Confirm drawn overlay correct #770

Closed
DominicOram opened this issue Jun 30, 2023 · 3 comments · Fixed by #802
Closed

Confirm drawn overlay correct #770

DominicOram opened this issue Jun 30, 2023 · 3 comments · Fixed by #802
Assignees
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

When we draw the grid on the OAV we want the centre of each box to indicate where data was taken. When we supply the grid to the fast motion control program we supply the first point to be taken and the subsequent steps. We need to make sure these are as expected.

Acceptance Criteria

  • We reason about the overlay and see if we think it is correct
  • We write a test_grid_scan plan that we can a single 2D scan against a foil and confirm positions
@DominicOram
Copy link
Collaborator Author

From looking at the code I think the drawing is wrong, we use upper_left for both the motion controller start position (which defines the first centre) and the value in ispyb (which defines the upper left pixel to draw e.g. the upper left of the first box)

@DominicOram
Copy link
Collaborator Author

With above fix, confirmed at https://ispyb.diamond.ac.uk/dc/visit/cm33866-3/id/10979217. This was done using the calibrate_grids branch that's in prod. To finish off this ticket:

  • Fix the above properly
  • Get the calibrate code tidied up so that we can use it again if required

@DominicOram
Copy link
Collaborator Author

In discussion with Neil decided to not tidy what we currently have for calibration and instead redo it in DiamondLightSource/mx-bluesky#352

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needed_for_release Issues that must be complete before the next release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant