Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Deploy v9.1.0 and test #1244

Closed
DominicOram opened this issue Mar 11, 2024 · 5 comments · Fixed by #1319
Closed

Deploy v9.1.0 and test #1244

DominicOram opened this issue Mar 11, 2024 · 5 comments · Fixed by #1319
Assignees

Comments

@DominicOram
Copy link
Collaborator

We've done a big refactor, we should make sure it works.

Acceptance Criteria

  • The new refactor is deployed
  • It is soak tested on a test puck and works
@DominicOram
Copy link
Collaborator Author

We think 1 day

@DominicOram DominicOram changed the title Deploy the ispyb refactor and soak test Deploy v9.1.0 and test Apr 15, 2024
@DominicOram
Copy link
Collaborator Author

Make sure to test collecting rotations in a group

@DominicOram
Copy link
Collaborator Author

DominicOram commented Apr 16, 2024

Issues found in testing:

  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/src/hyperion/device_setup_plans/read_hardware_for_setup.py", line 35, in read_hardware_for_ispyb_pre_collection
    yield from bps.save()
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/plan_stubs.py", line 87, in save
    return (yield Msg('save'))
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/preprocessors.py", line 251, in msg_mutator
    _s = yield msg
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/preprocessors.py", line 251, in msg_mutator
    _s = yield msg
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/preprocessors.py", line 251, in msg_mutator
    _s = yield msg
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 1607, in _run
    new_response = await coro(msg)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 1988, in _save
    await current_run.save(msg)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/bundlers.py", line 554, in save
    await self.emit(DocumentNames.event, event_doc)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 2572, in emit
    self.emit_sync(name, doc)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 2569, in emit_sync
    self.dispatcher.process(name, doc)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 2592, in process
    exceptions = self.cb_registry.process(name, name.name, doc)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/utils/__init__.py", line 385, in process
    func(*args, **kwargs)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/utils/__init__.py", line 474, in __call__
    return mtd(*args, **kwargs)
  File "/dls_sw/i03/software/bluesky/hyperion_v9.1.0/hyperion/.venv/lib/python3.10/site-packages/bluesky/callbacks/zmq.py", line 91, in __call__
    self._serializer(doc)])
_pickle.PicklingError: Can't pickle <enum 'GeneratedChoices'>: attribute lookup GeneratedChoices on ophyd_async.epics._backend.common failed

@DominicOram
Copy link
Collaborator Author

Left two branches on I03 GDA:

  • I03_live_hyperion_9_0_0
  • I03_live_hyperion_9_1_0

@DominicOram DominicOram self-assigned this Apr 18, 2024
@DominicOram
Copy link
Collaborator Author

Further testing today:

  • Need to convert from the synchrotron enum in the ispyb callback
  • Grid detect callback is specifying the transmission at 0.01 rather than 1

DominicOram added a commit that referenced this issue Apr 19, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant