Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Tidy from change to Ophyd-async edge detection #1219

Closed
dperl-dls opened this issue Mar 5, 2024 · 1 comment · Fixed by #1269
Closed

Tidy from change to Ophyd-async edge detection #1219

dperl-dls opened this issue Mar 5, 2024 · 1 comment · Fixed by #1269
Assignees
@dperl-dls

Comments

@dperl-dls
Copy link
Collaborator

dperl-dls commented Mar 5, 2024 •
edited by DominicOram
Loading

After DiamondLightSource/dodal#358 and #1214, the AreaDetector plugin for edge detection is no longer needed; we should remove it from Dodal and any plans which relate to it from Hyperion

  • Rename the PinTipDetection to something like EdgeDetection
  • Remove optional MXSC use from hyperion plans
  • Remove MXSC from dodal, changing the built in utils which use it
  • Remove the parameter that turns this on from Hyperion/GDA
This was referenced Mar 5, 2024
Merged
Closed
@DominicOram
Copy link
Collaborator

Mostly tidying tests ~1 day

@dperl-dls dperl-dls self-assigned this Mar 14, 2024
dperl-dls added a commit that referenced this issue Mar 14, 2024
@dperl-dls
#1219 remove mxsc and start fixing some tests
1df1410
dperl-dls added a commit that referenced this issue Mar 18, 2024
@dperl-dls
#1219 fix pin tip tests
9605bab
@dperl-dls dperl-dls mentioned this issue Mar 18, 2024
Merged
dperl-dls added a commit that referenced this issue Mar 27, 2024
@dperl-dls
(#1219) remove redundant comment
8bf81d7
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1219 remove mxsc and start fixing some tests
5896d7f
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
DiamondLightSource/hyperion#1219 fix pin tip tests
5a2ad4e
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@dperl-dls
(DiamondLightSource/hyperion#1219) remove redundant comment
329f6da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dperl-dls dperl-dls

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove MXSC (edge detection) AD plugin device DiamondLightSource/hyperion
2 participants
@DominicOram @dperl-dls