Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Fixes for ophyd async types mega merge #858

Draft
wants to merge 5 commits into
base: mx-bluesky_475_multi_centre_plan
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 22, 2024

Fixes breakages in dodal for bluesky/ophyd-async#594

Note this fix depends on #814

TODO

  • Unit tests currently failing due to signal names being clobbered on assignment
  • Unit tests currently ignored due to assert_configuration() in ophyd async not working for numpy arrays
  • panda constructor needs an appropriate URI
  • PMACStringFoo devices need to be changed as Signals-inside-signals are no longer permitted
  • FluorescenceDetectorControlState needs to be either a str-based StrictEnum with appropriate values

Instructions to reviewer on how to test:

  1. Unit tests pass
  2. Check the following changes:
    • Usage of StrictEnum/SubsetEnum is appropriate
    • Conversion of signals to numpy array types is appropriate

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 force-pushed the mx-bluesky_475_multi_centre_plan branch from 65bf6a3 to 303869f Compare October 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant