Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the horizontal mirror voltages #834

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

DominicOram
Copy link
Contributor

See DiamondLightSource/mx-bluesky#521

Also refactors the tests a bit to make it clearer what is under test

Instructions to reviewer on how to test:

  1. Confirm dodal connect i03 passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Refactor the tests that are testing logic of one channel to be clearer that's what they're doing.
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (32d252c) to head (ccfcce1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #834   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         120      120           
  Lines        4982     4985    +3     
=======================================
+ Hits         4743     4746    +3     
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dperl-dls dperl-dls merged commit 4f4a2fc into main Oct 21, 2024
18 checks passed
@dperl-dls dperl-dls deleted the mx_bluesky_521_expand_voltages branch October 21, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants