Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return no results if CPU and GPU agree on no results #819

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Oct 7, 2024

Fixes DiamondLightSource/mx-bluesky#545

Instructions to reviewer on how to test:

  1. Confirm test fails on main and passes here

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (0f8989e) to head (d306fe1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   95.19%   95.20%           
=======================================
  Files         120      120           
  Lines        4979     4982    +3     
=======================================
+ Hits         4740     4743    +3     
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - not sure if you linked the correct issue though?

@dperl-dls dperl-dls merged commit 32d252c into main Oct 21, 2024
18 checks passed
@dperl-dls dperl-dls deleted the mx_bluesky_545_hyperion_hotfixes branch October 21, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperion testing 01/10
3 participants