Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub offsets to smargon #230

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Add stub offsets to smargon #230

merged 4 commits into from
Nov 13, 2023

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Nov 9, 2023

Needed for DiamondLightSource/hyperion#794

Instructions to reviewer on how to test:

  1. Confirm unit tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #230 (b8f9eab) into main (8498a43) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   88.06%   88.19%   +0.12%     
==========================================
  Files          72       72              
  Lines        2555     2583      +28     
==========================================
+ Hits         2250     2278      +28     
  Misses        305      305              
Files Coverage Δ
src/dodal/devices/smargon.py 100.00% <100.00%> (ø)
src/dodal/devices/status.py 100.00% <100.00%> (ø)
src/dodal/devices/utils.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@dperl-dls dperl-dls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DominicOram DominicOram merged commit 817c447 into main Nov 13, 2023
16 checks passed
@DominicOram DominicOram deleted the 794_stub_offsets_simplified branch November 13, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants