Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_beamline_based_on_env_variable #166

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Conversation

Tom-Willemsen
Copy link
Contributor

Suggested in DiamondLightSource/hyperion#871 (comment)

Useful for hyperion, update PR at DiamondLightSource/hyperion#871 to use this once this is merged here.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #166 (4592b4f) into main (eed89e7) will decrease coverage by 1.45%.
Report is 63 commits behind head on main.
The diff coverage is 85.38%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   90.33%   88.89%   -1.45%     
==========================================
  Files          64       67       +3     
  Lines        2122     2332     +210     
==========================================
+ Hits         1917     2073     +156     
- Misses        205      259      +54     
Files Changed Coverage Δ
src/dodal/beamlines/i03.py 87.14% <ø> (ø)
src/dodal/devices/aperturescatterguard.py 73.21% <ø> (ø)
src/dodal/devices/oav/oav_calculations.py 100.00% <ø> (ø)
src/dodal/devices/oav/oav_detector.py 97.36% <ø> (-0.20%) ⬇️
src/dodal/devices/oav/oav_parameters.py 93.82% <ø> (ø)
...l/devices/oav/pin_image_recognition/manual_test.py 0.00% <0.00%> (ø)
src/dodal/log.py 98.78% <ø> (ø)
...c/dodal/devices/oav/pin_image_recognition/utils.py 74.03% <74.03%> (ø)
src/dodal/beamlines/i23.py 88.23% <88.23%> (ø)
src/dodal/devices/i23/gonio.py 92.30% <92.30%> (ø)
... and 8 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, take it or leave it

src/dodal/utils.py Outdated Show resolved Hide resolved
@DominicOram DominicOram merged commit 7735163 into main Sep 11, 2023
14 of 16 checks passed
@DominicOram DominicOram deleted the add_get_beamline_module branch September 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants