Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stage synchronous if arming not yet started #76

Closed
DominicOram opened this issue May 30, 2023 · 0 comments · Fixed by #92
Closed

Make stage synchronous if arming not yet started #76

DominicOram opened this issue May 30, 2023 · 0 comments · Fixed by #92
Assignees
@olliesilvester

Comments

@DominicOram
Copy link
Contributor

With #43 the stage of the eiger no longer exists. We should reinstate it so that:

  • If the Eiger has already been armed it does nothing
  • If the async_stage has started it waits on it to complete
  • If the async_stage has not started it starts it and waits on it to complete

This may be the cause of DiamondLightSource/hyperion#686, we should confirm if this is fixed after we do this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olliesilvester olliesilvester

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
2 participants
@DominicOram @olliesilvester