Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logging and detector mask #142

Merged
merged 16 commits into from
Sep 16, 2024
Merged

Add Logging and detector mask #142

merged 16 commits into from
Sep 16, 2024

Conversation

tizayi
Copy link
Collaborator

@tizayi tizayi commented Aug 29, 2024 •
edited
Loading

  • Adds some logging
  • Adds a detector mask
  • Corrects error in calculation of s
  • Small changes to the layout

resolves #2

@tizayi tizayi requested a review from stan-dot August 29, 2024 09:45
stan-dot
stan-dot requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@stan-dot stan-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small code clarity and maintainability changes

src/plot/centrePlot.tsx Outdated Show resolved Hide resolved
src/plot/legendBar.tsx Show resolved Hide resolved
src/plot/plotStore.ts Outdated Show resolved Hide resolved
src/plot/svgMask.tsx Outdated Show resolved Hide resolved
src/plot/svgMask.tsx Outdated Show resolved Hide resolved
src/presets/presetManager.ts Outdated Show resolved Hide resolved
src/results/rangeTable.tsx Outdated Show resolved Hide resolved
src/results/rangeTable.tsx Outdated Show resolved Hide resolved
src/results/resultsBar.tsx Outdated Show resolved Hide resolved
src/results/resultsBar.tsx Outdated Show resolved Hide resolved
@tizayi tizayi requested a review from stan-dot September 3, 2024 08:30
stan-dot
stan-dot requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@stan-dot stan-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides some typo, all is good

src/dialogs/detectorDialog.tsx Outdated Show resolved Hide resolved
src/plot/plotStore.ts Outdated Show resolved Hide resolved
src/plot/svgMask.tsx Show resolved Hide resolved
src/presets/presetManager.ts Outdated Show resolved Hide resolved
stan-dot
stan-dot approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@stan-dot stan-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tizayi tizayi merged commit a8067f5 into main Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stan-dot stan-dot stan-dot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mask and calibrant do nothing
2 participants
@tizayi @stan-dot