Using Composition over Inheritance #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tizayi
commented
May 22, 2024
•
tizayi
commented
- Separates beamline types from Appconfig/ preset types.
- Distinguishes between App types which use Unit from mathjs and IO types which have use numbers assumed to be in default units.
- Uses composition for zustand stores
- Makes sure useMemo works so q-ranges are not recalculated every re-render
- Uses react-form-hook to allow the user to add new beamlines and detectors
- resolves Expression produces a union type that is too complex to represent.ts(2590) #62
- resolves create new detectors and configs #5
- Updates layout for dialogs and main app
stan-dot
reviewed
May 22, 2024
| }); | ||
| } | ||
|
|
||
| const { register, reset, handleSubmit } = useForm<DetectorForm>(); |
There was a problem hiding this comment.
I really like this refactor, makes it much nicer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.