Fix state update on an unmounted component #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the machine-status client to use
vite
andvitest
I noticed that I was getting some warnings when running the tests:As it states, it is due to it trying to update the state on an unmounted component. This might not be an issue in production but is highlighted in the tests as the component gets unmounted almost immediately after mounting.
To eliminate this I have simply added a check that the component is mounted before updating the state and then have added a return function which is called when the component is unmounted and can set the
isMounted
check variable tofalse
.