Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bob widget issues #56

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Fix bob widget issues #56

merged 9 commits into from
Jun 6, 2024

Conversation

abigailalexander
Copy link
Collaborator

This PR fixes various issues with widgets that I noticed when using .bob files:

  • Added image_stretch field (this is stretch_to_fit in .opi files)
  • Modified bobParseFonts to use strings instead of numbers as keys
  • Added a check for whether a .opi or .bob file is used for rules, as .opi uses pv_name and .bob uses pv
  • Changed default background and text colour for Label and Readback to match with Phoebus defaults

rjwills28
rjwills28 reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@rjwills28 rjwills28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. I've just added a few comments/suggestions.

src/ui/widgets/EmbeddedDisplay/bobParser.ts Outdated Show resolved Hide resolved
src/ui/widgets/Readback/readback.module.css Outdated Show resolved Hide resolved
@abigailalexander abigailalexander merged commit c29ff72 into master Jun 6, 2024
2 checks passed
@abigailalexander abigailalexander deleted the fix-bob-widget-issues branch September 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjwills28 rjwills28 rjwills28 approved these changes

@MJGaughran MJGaughran Awaiting requested review from MJGaughran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abigailalexander @rjwills28